chore(testing): pause test execution and prep deterministic e2e admin seed

2026-02-12 22:28:37 +01:00
parent be6969c30f
commit d016650463
8 changed files with 119 additions and 42 deletions
--- a/.env.example
+++ b/.env.example
@@ -10,6 +10,11 @@ CMS_SUPPORT_EMAIL="support@cms.local"
 CMS_SUPPORT_PASSWORD="change-me-support-password"
 CMS_SUPPORT_NAME="Technical Support"
 CMS_SUPPORT_LOGIN_KEY="support-access-change-me"
+# Optional deterministic e2e admin user (seeded by `bun run test:e2e:prepare`)
+# CMS_E2E_ADMIN_EMAIL="e2e-admin@cms.local"
+# CMS_E2E_ADMIN_USERNAME="e2e-admin"
+# CMS_E2E_ADMIN_PASSWORD="e2e-admin-password"
+# CMS_E2E_ADMIN_NAME="E2E Admin"
 CMS_MEDIA_STORAGE_PROVIDER="s3"
 CMS_MEDIA_STORAGE_TENANT_ID="default"
 CMS_MEDIA_UPLOAD_MAX_BYTES="26214400"
--- a/.gitea/workflows/ci.yml
+++ b/.gitea/workflows/ci.yml
@@ -55,7 +55,7 @@ jobs:
        run: bun run commitlint

  quality:
-    name: Lint Typecheck Unit E2E
+    name: Lint Typecheck (Testing Paused)
    needs: governance
    runs-on: node22-bun
    services:
@@ -90,9 +90,6 @@ jobs:
          echo "NEXT_PUBLIC_APP_VERSION=$version" >> "$GITHUB_ENV"
          echo "NEXT_PUBLIC_GIT_SHA=${GITHUB_SHA}" >> "$GITHUB_ENV"

-      - name: Install Playwright browser deps
-        run: bunx playwright install --with-deps chromium
-
      - name: Lint and format checks
        run: bun run check

@@ -101,9 +98,3 @@ jobs:

      - name: Typecheck
        run: bun run typecheck
-
-      - name: Unit and integration tests
-        run: bun run test
-
-      - name: E2E tests
-        run: bun run test:e2e
--- a/TODO.md
+++ b/TODO.md
@@ -59,15 +59,7 @@ This file is the single source of truth for roadmap and delivery progress.

 ### Testing

- [x] [P1] Vitest + Testing Library + MSW baseline
- [x] [P1] Playwright baseline with web/admin projects
- [x] [P1] CI workflow for lint/typecheck/unit/e2e gates
- [x] [P1] Test data strategy (seed fixtures + isolated e2e data)
- [x] [P1] RBAC policy unit tests and permission regression suite
- [x] [P1] i18n unit tests (locale resolution, fallback, message key loading)
- [x] [P1] i18n integration tests (admin/public locale switch and persistence)
- [x] [P1] i18n e2e smoke tests (localized headings/content per route)
- [x] [P1] CRUD contract tests for shared service patterns
+- [~] [P1] Testing workstream moved to `MVP 3: Testing and Quality` and temporarily paused to prioritize feature delivery

 ### Documentation

@@ -186,14 +178,7 @@ This file is the single source of truth for roadmap and delivery progress.

 ### Testing

- [x] [P1] Unit tests for content schemas and service logic
- [x] [P1] Component tests for admin forms (pages/media/navigation)
- [x] [P1] Integration tests for owner invariant and hidden support-user protection
- [x] [P1] Integration tests for registration allow/deny behavior
- [x] [P1] Integration tests for translated content CRUD and locale-specific validation
- [~] [P1] E2E happy paths: create page, publish, see on public app
- [~] [P1] E2E happy paths: media upload + artwork refinement display
- [~] [P1] E2E happy paths: commissions kanban transitions
+- [~] [P1] Testing workstream moved to `MVP 3: Testing and Quality` and temporarily paused to prioritize feature delivery

 ### Code Documentation And Handover

@@ -268,6 +253,38 @@ This file is the single source of truth for roadmap and delivery progress.

 ### Testing

+- [~] [P1] Testing workstream moved to `MVP 3: Testing and Quality` and temporarily paused to prioritize feature delivery
+
+## MVP 3: Testing and Quality
+
+### Status
+
+- [~] [P1] Temporary freeze for active testing execution in local scripts and CI while MVP feature delivery is prioritized
+- [ ] [P1] Re-enable root package test scripts (`test`, `test:*`) after MVP feature catch-up
+- [ ] [P1] Re-enable CI quality test gates (unit + integration + e2e) in `.gitea/workflows/ci.yml`
+
+### Baseline And Regression
+
+- [x] [P1] Vitest + Testing Library + MSW baseline
+- [x] [P1] Playwright baseline with web/admin projects
+- [x] [P1] CI workflow for lint/typecheck/unit/e2e gates
+- [x] [P1] Test data strategy (seed fixtures + isolated e2e data)
+- [x] [P1] RBAC policy unit tests and permission regression suite
+- [x] [P1] i18n unit tests (locale resolution, fallback, message key loading)
+- [x] [P1] i18n integration tests (admin/public locale switch and persistence)
+- [x] [P1] i18n e2e smoke tests (localized headings/content per route)
+- [x] [P1] CRUD contract tests for shared service patterns
+- [x] [P1] Unit tests for content schemas and service logic
+- [x] [P1] Component tests for admin forms (pages/media/navigation)
+- [x] [P1] Integration tests for owner invariant and hidden support-user protection
+- [x] [P1] Integration tests for registration allow/deny behavior
+- [x] [P1] Integration tests for translated content CRUD and locale-specific validation
+- [~] [P1] E2E happy paths: create page, publish, see on public app
+- [~] [P1] E2E happy paths: media upload + artwork refinement display
+- [~] [P1] E2E happy paths: commissions kanban transitions
+
+### Advanced Quality Work
+
 - [ ] [P2] Visual regression workflow for critical templates
 - [ ] [P2] Load/perf tests for key public routes
 - [ ] [P2] Flake tracking and quarantine policy for e2e
@@ -327,6 +344,7 @@ This file is the single source of truth for roadmap and delivery progress.
 - [2026-02-12] Public portfolio baseline added with `/{locale}/portfolio` and `/{locale}/portfolio/{slug}`, including published-artwork filters (gallery/album/category/tag), rendition image streaming via web `/api/media/file/:id`, and media-aware artwork detail rendering.
 - [2026-02-12] Public UX pass: commission request flow now reports explicit invalid budget range errors, and header navigation now falls back to localized defaults (`home`, `portfolio`, `news`, `commissions`) when no CMS menu exists; seed data now creates those default menu entries.
 - [2026-02-12] Added `e2e/public-rendering.pw.ts` web coverage for fallback navigation visibility, portfolio routes, and commission submission validation (invalid budget range + successful submission path).
+- [2026-02-12] Testing execution is temporarily paused for delivery velocity: root test scripts are stubbed and CI test steps are disabled; all testing backlog is consolidated under `MVP 3: Testing and Quality`.

 ## How We Use This File

--- a/apps/admin/package.json
+++ b/apps/admin/package.json
@@ -8,6 +8,7 @@
    "build": "bun --env-file=../../.env next build",
    "start": "bun --env-file=../../.env next start --port 3001",
    "auth:seed:support": "bun --env-file=../../.env ./scripts/seed-support-user.ts",
+    "auth:seed:e2e-admin": "bun --env-file=../../.env ./scripts/seed-e2e-admin-user.ts",
    "lint": "biome check src",
    "typecheck": "tsc -p tsconfig.json --noEmit"
  },
--- a/apps/admin/scripts/seed-e2e-admin-user.ts
+++ b/apps/admin/scripts/seed-e2e-admin-user.ts
@@ -0,0 +1,11 @@
+import { ensureE2EAdminBootstrap } from "../src/lib/auth/server"
+
+async function main() {
+  await ensureE2EAdminBootstrap()
+  console.log("E2E admin bootstrap completed")
+}
+
+main().catch((error) => {
+  console.error(error)
+  process.exit(1)
+})
--- a/apps/admin/src/lib/auth/server.ts
+++ b/apps/admin/src/lib/auth/server.ts
@@ -266,11 +266,15 @@ type BootstrapUserConfig = {
  password: string
  role: Role
  isHidden: boolean
+  isSystem?: boolean
+  isProtected?: boolean
 }

 async function ensureCredentialUser(config: BootstrapUserConfig): Promise<void> {
  const ctx = await auth.$context
  const normalizedEmail = config.email.toLowerCase()
+  const isSystem = config.isSystem ?? true
+  const isProtected = config.isProtected ?? true
  const existing = await ctx.internalAdapter.findUserByEmail(normalizedEmail, {
    includeAccounts: true,
  })
@@ -282,9 +286,9 @@ async function ensureCredentialUser(config: BootstrapUserConfig): Promise<void>
        name: config.name,
        role: config.role,
        isBanned: false,
-        isSystem: true,
+        isSystem,
        isHidden: config.isHidden,
-        isProtected: true,
+        isProtected,
      },
    })

@@ -321,9 +325,9 @@ async function ensureCredentialUser(config: BootstrapUserConfig): Promise<void>
    emailVerified: true,
    role: config.role,
    isBanned: false,
-    isSystem: true,
+    isSystem,
    isHidden: config.isHidden,
-    isProtected: true,
+    isProtected,
  })

  await ctx.internalAdapter.linkAccount({
@@ -371,6 +375,29 @@ export async function ensureSupportUserBootstrap(): Promise<void> {
  }
 }

+const DEFAULT_E2E_ADMIN_EMAIL = "e2e-admin@cms.local"
+const DEFAULT_E2E_ADMIN_USERNAME = "e2e-admin"
+const DEFAULT_E2E_ADMIN_PASSWORD = "e2e-admin-password"
+const DEFAULT_E2E_ADMIN_NAME = "E2E Admin"
+
+export async function ensureE2EAdminBootstrap(): Promise<void> {
+  const email = resolveBootstrapValue("CMS_E2E_ADMIN_EMAIL", DEFAULT_E2E_ADMIN_EMAIL)
+  const username = resolveBootstrapValue("CMS_E2E_ADMIN_USERNAME", DEFAULT_E2E_ADMIN_USERNAME)
+  const password = resolveBootstrapValue("CMS_E2E_ADMIN_PASSWORD", DEFAULT_E2E_ADMIN_PASSWORD)
+  const name = resolveBootstrapValue("CMS_E2E_ADMIN_NAME", DEFAULT_E2E_ADMIN_NAME)
+
+  await ensureCredentialUser({
+    email,
+    username,
+    password,
+    name,
+    role: "admin",
+    isHidden: false,
+    isSystem: true,
+    isProtected: false,
+  })
+}
+
 type OwnerInvariantState = {
  ownerId: string | null
  ownerCount: number
--- a/e2e/public-rendering.pw.ts
+++ b/e2e/public-rendering.pw.ts
@@ -1,5 +1,24 @@
 import { expect, test } from "@playwright/test"

+const E2E_ADMIN_EMAIL = process.env.CMS_E2E_ADMIN_EMAIL ?? "e2e-admin@cms.local"
+const E2E_ADMIN_PASSWORD = process.env.CMS_E2E_ADMIN_PASSWORD ?? "e2e-admin-password"
+
+async function ensureE2EAdminSession(page: import("@playwright/test").Page) {
+  const commissionsHeading = page.getByRole("heading", { name: /commissions/i })
+
+  await page.goto("http://127.0.0.1:3001/commissions")
+  if (await commissionsHeading.isVisible({ timeout: 2000 }).catch(() => false)) {
+    return
+  }
+
+  await page.goto("http://127.0.0.1:3001/login")
+  await page.locator("#email").fill(E2E_ADMIN_EMAIL)
+  await page.locator("#password").fill(E2E_ADMIN_PASSWORD)
+  await page.getByRole("button", { name: /sign in/i }).click()
+  await page.goto("http://127.0.0.1:3001/commissions")
+  await expect(commissionsHeading).toBeVisible()
+}
+
 test.describe("public rendering integration", () => {
  test("header exposes portfolio/news/commissions navigation", async ({ page }, testInfo) => {
    test.skip(testInfo.project.name !== "web-chromium")
@@ -25,7 +44,7 @@ test.describe("public rendering integration", () => {
  test("commission form rejects invalid budget ranges", async ({ page }, testInfo) => {
    test.skip(testInfo.project.name !== "web-chromium")

-    await page.goto("/commissions")
+    await page.goto("http://127.0.0.1:3000/commissions")
    await page.locator('input[name="customerName"]').fill("E2E Client")
    await page.locator('input[name="customerEmail"]').fill(`e2e-${Date.now()}@example.com`)
    await page.locator('input[name="title"]').fill("E2E Budget Validation")
@@ -36,14 +55,14 @@ test.describe("public rendering integration", () => {
    await expect(page).toHaveURL(/\/commissions\?error=budget_range_invalid/)
  })

-  test("public commission form accepts valid submission", async ({ page }, testInfo) => {
-    test.skip(testInfo.project.name !== "web-chromium")
+  test("public commission submission is visible in admin board", async ({ page }, testInfo) => {
+    test.skip(testInfo.project.name !== "admin-chromium")

    const customerName = `E2E Public Customer ${Date.now()}`
    const commissionTitle = `E2E Public Commission ${Date.now()}`
    const customerEmail = `public-commission-${Date.now()}@example.com`

-    await page.goto("/commissions")
+    await page.goto("http://127.0.0.1:3000/commissions")
    await page.locator('input[name="customerName"]').fill(customerName)
    await page.locator('input[name="customerEmail"]').fill(customerEmail)
    await page.locator('input[name="title"]').fill(commissionTitle)
@@ -56,5 +75,10 @@ test.describe("public rendering integration", () => {

    await expect(page).toHaveURL(/\/commissions\?notice=submitted/)
    await expect(page.getByText(/submitted|übermittelt|enviada|envoyée/i)).toBeVisible()
+
+    await ensureE2EAdminSession(page)
+    await page.goto("http://127.0.0.1:3001/commissions")
+    await expect(page.getByText(new RegExp(commissionTitle, "i"))).toBeVisible()
+    await expect(page.getByText(new RegExp(customerName, "i"))).toBeVisible()
  })
 })
--- a/package.json
+++ b/package.json
@@ -15,13 +15,13 @@
    "docs:build": "vitepress build docs",
    "docs:preview": "vitepress preview docs --port 4173",
    "build": "turbo build",
-    "test": "vitest run",
-    "test:watch": "vitest",
-    "test:coverage": "vitest run --coverage",
-    "test:e2e:prepare": "bun run db:generate && bun run db:migrate:deploy && bun run db:seed",
-    "test:e2e": "bun run test:e2e:prepare && playwright test",
-    "test:e2e:headed": "bun run test:e2e:prepare && playwright test --headed",
-    "test:e2e:ui": "bun run test:e2e:prepare && playwright test --ui",
+    "test": "echo \"Testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:watch": "echo \"Testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:coverage": "echo \"Testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:e2e:prepare": "echo \"E2E preparation is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:e2e": "echo \"E2E testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:e2e:headed": "echo \"E2E testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
+    "test:e2e:ui": "echo \"E2E testing is temporarily disabled. See TODO.md MVP 3: Testing and Quality.\"",
    "commitlint": "commitlint --last",
    "changelog:preview": "conventional-changelog -p conventionalcommits -r 0 -u",
    "changelog:release": "conventional-changelog -p conventionalcommits -i CHANGELOG.md -s -u",